-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-33182 make all helm examples dropzone subpaths to "mydropzone" #19387
base: candidate-9.8.x
Are you sure you want to change the base?
HPCC-33182 make all helm examples dropzone subpaths to "mydropzone" #19387
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33182 Jirabot Action Result: |
@@ -40,7 +40,7 @@ planes: | |||
#shareName: datashare | |||
#volumeId: "100-data" | |||
- name: mydropzone | |||
subPath: dropzone | |||
subPath: mydropzone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ ../helm/examples$ fgrep -R dropzone | fgrep -i subpath
fsx/hpcc-fsx-dynamic-pv/values.yaml: subPath: dropzone
efs/hpcc-efs-dynamic-pv/values.yaml: subPath: dropzone
efs/hpcc-efs-static-pv/values.yaml: subPath: dropzone
esdl/values-hpcc-localfile.yaml: subPath: dropzone
local/hpcc-localfile/values.yaml: subPath: dropzone
azure/hpcc-azurefile/values.yaml: subPath: dropzone
nfs/hpcc-nfs/values.yaml: subPath: dropzone
all subPath's are currently (before this PR) "dropzone", and I think that's logical
In the same way other planes paths, e.g. data are not 'mydata'.
The prefix paths in the generated example files are not consistent though, i.e.:
/helm/examples$ fgrep -R dropzone | fgrep -i prefix
fsx/values-retained-fsx.yaml: prefix: "/var/lib/HPCCSystems/mydropzone"
efs/values-retained-efs.yaml: prefix: "/var/lib/HPCCSystems/mydropzone"
efs/values-auto-efs.yaml: prefix: "/var/lib/HPCCSystems/mydropzone"
esdl/values-echo-example-localfile.yaml: prefix: "/var/lib/HPCCSystems/dropzone"
local/values-localfile.yaml: prefix: "/var/lib/HPCCSystems/mydropzone"
azure/values-auto-azurefile.yaml: prefix: "/var/lib/HPCCSystems/mydropzone"
azure/values-retained-azurefile.yaml: prefix: "/var/lib/HPCCSystems/mydropzone"
the only that's right is esdl/values-echo-example-localfile.yaml.
I think it would be more consistent to change these to paths to /var/lib/HPCCSystems/dropzone
OR, drop 'my' altogether, use 'dropzone' for the plane name and the subPath (and hence the prefix too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xwang2713 - see comment.
There are some inconsistences for dropzone subpath in Helm Charts.
Some use "mydropzone" and the others use "dropzone"
Since our regression tests assume "mydropzone" and to make it consistent "mydropzone" will be used.
There is a seperate JIRA https://hpccsystems.atlassian.net/browse/HPCC-33183 for documentation.
Signed off by xiaoming.wang@lexisnexisrisk.com
Type of change:
Checklist:
Smoketest:
Testing:
Tested on Docker Desktop environment. This will fix Regress Quick Test pipe8.ecl with "dropzone" as subpath.