-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-33157 Std.Crypto.SymmetricEncryption() crash on empty ciphertext #19376
base: candidate-9.6.x
Are you sure you want to change the base?
HPCC-33157 Std.Crypto.SymmetricEncryption() crash on empty ciphertext #19376
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33157 Jirabot Action Result: |
throw makeStringExceptionV(-1, "Invalid cipher name length (%d) while deserializing ciphertext", len); | ||
|
||
sbCipher.append(len, finger);//extract cipher name | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lenPlainText is uninitialised in the caller.
else
*lenPlainText = 0;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Would also benefit from a test case to cover the error condition. |
Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please squash
0fb9b31
to
1e83bde
Compare
Squashed, please merge. Thanks! |
Type of change:
Checklist:
Smoketest:
Testing: