Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33041 ECL Watch UI test (GH Action) reports an error with 'Files' page. #19341

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HPCC-33041 ECL Watch UI test (GH Action) reports an error with 'Files' page. #19341

wants to merge 2 commits into from

Conversation

AttilaVamos
Copy link
Contributor

@AttilaVamos AttilaVamos commented Dec 5, 2024 •
edited
Loading

ActivitiesTest.java:

  • Change the 'should match' behaviour to a 'looks like' attempt when the test tries to identify a WEB page where it is landed after clicked a hyperlink..

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Tested locally.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33041

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@AttilaVamos AttilaVamos force-pushed the HPCC-33041-fix-master branch from 6ebea20 to 5551d4f Compare December 5, 2024 16:23
@AttilaVamos AttilaVamos requested a review from cloLN December 5, 2024 16:38
@AttilaVamos AttilaVamos force-pushed the HPCC-33041-fix-master branch from 5551d4f to e2c12a8 Compare December 5, 2024 17:02
cloLN
cloLN approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@cloLN cloLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable.

@AttilaVamos
Copy link
Contributor Author

@ghalliday please merge.

@ghalliday
Copy link
Member

@AttilaVamos please rebase to avoid the merge conflicts. Thanks.

ghalliday
ghalliday reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AttilaVamos a couple of comments/questions

.github/workflows/test-ui-gh_runner.yml Outdated
@@ -148,7 +148,8 @@ jobs:
export PATH=$PATH:$JAVA_HOME/bin
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
sudo apt-get install -y ./google-chrome-stable_current_amd64.deb
wget https://storage.googleapis.com/chrome-for-testing-public/126.0.6478.126/linux64/chromedriver-linux64.zip
#wget https://storage.googleapis.com/chrome-for-testing-public/126.0.6478.126/linux64/chromedriver-linux64.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, removed

.github/workflows/test-ui-gh_runner.yml Outdated
@@ -185,7 +186,7 @@ jobs:
if: ${{ failure() || cancelled() || env.uploadArtifact == 'true' }}
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.asset-name }}-ecl_watch_ui_tests
name: ${{ inputs.asset-name }}-ecl_watch_ui_tests_logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change deliberate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the ecl_watch_ui_tests artifact already exists (created by the build phase) and the actions/upload-artifact@v4 forbid to use existing name.

esp/src/test-ui/tests/framework/pages/ActivitiesTest.java Outdated
for (NavigationWebElement element : navWebElements) {

StringBuilder erorMmsg = new StringBuilder("OK");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial: typo errorMsg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

esp/src/test-ui/tests/framework/pages/ActivitiesTest.java Outdated
List<String> tabsList = URLConfig.tabsListMap.get(element.name());
int numOfElemets = tabsList.size();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: numOfElements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

esp/src/test-ui/tests/framework/pages/ActivitiesTest.java Outdated

return true;

if ( (elementFound / numOfElemets) < 0.5 ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to protect against numElements == 0 (and return early?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@AttilaVamos
HPCC-33041 ECL Watch UI test (GH Action) reports an error with 'Files…
7063862 
…' page.

ActivitiesTest.java:
- Change the 'should match' behaviour to a 'looks like' attempt when the test
  tries to identify a WEB page where it is landed after clicked a hyperlink..

test-ui-gh_runner.yml:
- Change Chromedriver vesion (PR-19330 not merged yet)
- Fix the tests log artifact name

Tested locally.

Signed-off-by: Attila Vamos <attila.vamos@gmail.com>
@AttilaVamos AttilaVamos force-pushed the HPCC-33041-fix-master branch from e2c12a8 to f6ed994 Compare January 7, 2025 12:14
@AttilaVamos AttilaVamos requested review from cloLN and ghalliday January 7, 2025 12:15
@AttilaVamos
Changes based on review.
fc84c3d 
Signed-off-by: Attila Vamos <attila.vamos@gmail.com>
@AttilaVamos AttilaVamos force-pushed the HPCC-33041-fix-master branch from f6ed994 to fc84c3d Compare January 7, 2025 12:52
ghalliday
ghalliday approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please squash when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

@cloLN cloLN Awaiting requested review from cloLN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AttilaVamos @ghalliday @cloLN