Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32699 Encode all ALA response data #19137

Merged
merged 1 commit into from
Sep 25, 2024
Merged

HPCC-32699 Encode all ALA response data #19137

merged 1 commit into from
Sep 25, 2024

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Sep 20, 2024 •
edited
Loading

  • Encodes all response log data from ALA

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@rpastrana
Copy link
Member Author

@jeclrsg fyi

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32699

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@rpastrana rpastrana force-pushed the HPCC-32699-ALA-Encode branch from ba5a269 to 2d7f6cd Compare September 24, 2024 16:36
@rpastrana rpastrana requested a review from ghalliday September 24, 2024 16:43
ghalliday
ghalliday reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, a couple of minor comments.

system/logaccess/Azure/LogAnalytics/CurlClient/AzureLogAnalyticsCurlClient.cpp Outdated
@@ -947,7 +947,17 @@ unsigned AzureLogAnalyticsCurlClient::processHitsJsonResp(IPropertyTreeIterator
ForEach(*fields)
{
const char * fieldName = header.item(idx++);
returnbuf.appendf("<%s>%s</%s>", fieldName, fields->query().queryProp("."), fieldName);
StringBuffer encodedValue;
StringBuffer rawValue(fields->query().queryProp("."));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor efficiency:

const char * rawValue = fields->query().queryProp(".");

it avoids cloning the string.

system/logaccess/Azure/LogAnalytics/CurlClient/AzureLogAnalyticsCurlClient.cpp Outdated
@@ -947,7 +947,17 @@ unsigned AzureLogAnalyticsCurlClient::processHitsJsonResp(IPropertyTreeIterator
ForEach(*fields)
{
const char * fieldName = header.item(idx++);
returnbuf.appendf("<%s>%s</%s>", fieldName, fields->query().queryProp("."), fieldName);
StringBuffer encodedValue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial: encodedValue can be moved inside the else

@rpastrana
HPCC-32699 Encode all ALA response data
006814c 
- Encodes all response log data from ALA

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
@rpastrana rpastrana force-pushed the HPCC-32699-ALA-Encode branch from 2d7f6cd to 006814c Compare September 25, 2024 14:42
@rpastrana rpastrana requested a review from ghalliday September 25, 2024 14:44
@rpastrana
Copy link
Member Author

@ghalliday changes squashed

@ghalliday ghalliday merged commit b211000 into hpcc-systems:candidate-9.6.x Sep 25, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpastrana @ghalliday