Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-29904 Remove generated code that builds the XSD and WSDL #18379

Merged
merged 1 commit into from
Mar 14, 2024
Merged

HPCC-29904 Remove generated code that builds the XSD and WSDL #18379

merged 1 commit into from
Mar 14, 2024

Conversation

kenrowland
Copy link
Contributor

@kenrowland kenrowland commented Mar 6, 2024 •
edited
Loading

Remove code from HIDL that generates the code that generates the XSD and
WSDL forms.

Signed-Off-By: Kenneth Rowland kenneth.rowland@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

afishbeckln
afishbeckln reviewed Mar 7, 2024
View reviewed changes
esp/bindings/http/platform/httpbinding.hpp Outdated
@@ -24,6 +24,8 @@

#include "bindutil.hpp"
#include "seclib.hpp"
//#include "esdl_def_helper.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove commented code. The history is still there.

afishbeckln
afishbeckln reviewed Mar 7, 2024
View reviewed changes
esp/bindings/http/platform/httpbinding.hpp Outdated
@@ -356,7 +358,7 @@ class esp_http_decl EspHttpBinding :
virtual int getMethodHelp(IEspContext &context, const char *serv, const char *method, StringBuffer &page);
bool isMethodInService(IEspContext& context, const char *servname, const char *methname);

virtual int getMethodHtmlForm(IEspContext &context, CHttpRequest* request, const char *serv, const char *method, StringBuffer &page, bool bIncludeFormTag){return 0;}
// virtual int getMethodHtmlForm(IEspContext &context, CHttpRequest* request, const char *serv, const char *method, StringBuffer &page, bool bIncludeFormTag){return 0;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove.

afishbeckln
afishbeckln reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@afishbeckln afishbeckln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenrowland It's great to see large chunks of the generated code being replaced with shared code. Just want to make sure thought... this has been well tested to make sure no functionailty is missing?

afishbeckln
afishbeckln approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@afishbeckln afishbeckln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places where commented code should be removed, but approving as is. You can still remove those comments.

@kenrowland kenrowland force-pushed the HPCC-29904 branch 3 times, most recently from bcc7a46 to c49657a Compare March 8, 2024 01:48
@kenrowland kenrowland changed the title HPCC-29554 Improve XSD form generation HPCC-29904 Remove generated code that builds the XSD and WSDL Mar 8, 2024
asselitx
asselitx requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@asselitx asselitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small corrections to comments, otherwise looks good.

tools/hidl/hidlcomp.cpp Outdated
outf("\t}\n");
}
}

outs("}\n");

//=======================================================================================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this three line comment block is for the getHtmlForm function output which was removed, so the comment should be too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

tools/hidl/hidlcomp.cpp Outdated

//method ==> getMethodHtmlForm
outs("\tvirtual int getMethodHtmlForm(IEspContext &context, CHttpRequest* request, const char *serv, const char *method, StringBuffer &page, bool bIncludeFormTag);\n");
// method ===> getXmlFilename
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct comment to read getServiceXmlFilename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@kenrowland kenrowland requested a review from asselitx March 9, 2024 00:25
@kenrowland
HPCC-29904 Remove generated code that builds the XSD and WSDL
69fc3b6 
Removed code from HIDL that generated the code that generated
XSD and WSDL forms

Signed-Off-By: Kenneth Rowland kenneth.rowland@lexisnexisrisk.com
@kenrowland kenrowland changed the base branch from master to candidate-9.6.x March 12, 2024 15:10
@kenrowland
Copy link
Contributor Author

@ghalliday Please merge

@ghalliday ghalliday merged commit e33dde2 into hpcc-systems:candidate-9.6.x Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afishbeckln afishbeckln afishbeckln approved these changes

@asselitx asselitx asselitx approved these changes

Assignees

@afishbeck afishbeck

@asselitx asselitx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kenrowland @asselitx @afishbeckln @ghalliday @afishbeck