Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu 22.04, OSX 13 and rockylinux-8 #18343

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Feb 26, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith force-pushed the HPCC-31313-UBUNTU-22_04 branch 3 times, most recently from d3b5fa1 to c5b537f Compare February 28, 2024 17:56
@GordonSmith GordonSmith changed the title WIP Bump vcpkg versions for 9.6.x Feb 28, 2024
@GordonSmith GordonSmith force-pushed the HPCC-31313-UBUNTU-22_04 branch from c5b537f to 46f9253 Compare February 29, 2024 16:52
@GordonSmith GordonSmith changed the base branch from candidate-9.4.x to master February 29, 2024 17:08
@GordonSmith GordonSmith reopened this Feb 29, 2024
@GordonSmith GordonSmith reopened this Feb 29, 2024
@GordonSmith GordonSmith force-pushed the HPCC-31313-UBUNTU-22_04 branch 2 times, most recently from a01b3a3 to c9ca79f Compare March 5, 2024 09:12
@GordonSmith GordonSmith marked this pull request as ready for review March 5, 2024 09:14
@GordonSmith GordonSmith requested a review from ghalliday March 5, 2024 09:14
@GordonSmith
Copy link
Member Author

Note: This is dependent on https://github.com/hpcc-systems/HPCC-Platform/pull/18365/files

@GordonSmith GordonSmith changed the title Bump vcpkg versions for 9.6.x Add support for Ubuntu 22.04, OSX 13 and rockylinux-8 Mar 5, 2024
@ghalliday
Copy link
Member

I have pushed a fix for the macos compile problem.

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith force-pushed the HPCC-31313-UBUNTU-22_04 branch from c9ca79f to 9efbb72 Compare March 6, 2024 13:23
@GordonSmith
Copy link
Member Author

@ghalliday this PR is also dependent on: #18364 (the OSX 13 fixes)

@GordonSmith GordonSmith mentioned this pull request Mar 7, 2024
39 tasks
@ghalliday ghalliday merged commit db52e95 into hpcc-systems:master Mar 8, 2024
49 of 51 checks passed
@GordonSmith GordonSmith deleted the HPCC-31313-UBUNTU-22_04 branch March 8, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants