HPCC-30847 Allow OpenTelemetry options to be configured in bare-metal

[afishbeck]

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

https://track.hpccsystems.com/browse/HPCC-30847
Jira updated

[afishbeck]

@ghalliday this is a more minimal change to get OpenTelemetry working on bare-metal. I think changing how ESP loads it's config is more dangerous and perhaps should target a new branch. But take a look at this change and decide if you'd rather take it further. If not we can open a JIRA for standardizing the ESP loadConfig to resemble other components.

[afishbeck]

@ghalliday Also if you could test this change against your OpenTelemetry config that would be good. I haven't really tested real otel options.

[ghalliday]

@afishbeck I'm not sure about this approach, because it is moving away from a general case processing, to special casing - and there is already one other example that was hitting the same issue.

Better is probably to pass in the default configuration and a mapping fucntion that only extracts the globals. @jakesmith is looking into a similar change.

[afishbeck]

@ghalliday agree about fixing config being the correct approach, just wasn't sure if you wanted something less risky for a point release.
I think with the config mapping approach you could still start fairly simply as far as what gets mapped in to the component and global config so I guess it could be done in a phased approach with less risk than it would first seem.

[afishbeck]

Gavin provided a proper fix where select values get mapped into the component config.