HPCC-31017 Report cause of k8s thorworker job failure

[jakesmith]

Ensure that the cause of the failure to apply the k8s thorworker job is reported back to the workunit.
Also suppress follow on 'backoff' failure if the primary cause of failure has already been reported.

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

https://track.hpccsystems.com/browse/HPCC-31017
Jira updated

[github-actions]

https://track.hpccsystems.com/browse/HPCC-31017
This pull request is already registered

[shamser]

Please can you clarify the question regarding suppressing thormanager exit failure?

[shamser]

If the exit failure is suppressed, does it mean that some error conditions will no longer be resolved thor manager exit failure handling (e.g. restarting thor)? i.e., does it mean continuing as if no error occurred, mean that the error condition could re-occur when the next job is processed?

[jakesmith]

This is containerized only, thor doesn't restart in k8s, existing instances are either reused or a new instance is spun up.
So this already reported error (to workunit) is suppressed to avoid the launcher of the instance (agentexec), which may be from a much earlier workunit, seeing the error, and reporting a k8s error "Job has reached the specified backoff limit".

In other words, if it gets this far, this thor instance has handled the error, reported it to our workflow, and is returning success to the agent to prevent it to report a spurious and confusing additional error.

[jakesmith]

@shamser - please see reply.

[github-actions]

https://track.hpccsystems.com/browse/HPCC-31017
This pull request is already registered