-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-30553 Add persistent tabs to "details" pages #18058
HPCC-30553 Add persistent tabs to "details" pages #18058
Conversation
https://track.hpccsystems.com/browse/HPCC-30553 |
esp/src/src-react/components/controls/TabbedPanes/OverflowMenu.tsx
Outdated
Show resolved
Hide resolved
esp/src/src-react/components/controls/TabbedPanes/OverflowMenu.tsx
Outdated
Show resolved
Hide resolved
f8eb39a
to
ce3b16e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GordonSmith Just saw a couple spots w/ some old commented out code. Also, when I checked this branch out, I noticed that the state wasn't being passed in correctly when you changed tabs. Though, I couldn't remember if that was one of the things we'd talked about earlier today & you'd said you still had changes to make on that.
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
e877abe
to
ebc1e92
Compare
@jeclrsg changes made as requested and added "tab state" support. |
Type of change:
Checklist:
Smoketest:
Testing: