Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30610 Include the tagging timestamp in the WUCheckFeatures response #17947

Merged
merged 1 commit into from
Nov 2, 2023
Merged

HPCC-30610 Include the tagging timestamp in the WUCheckFeatures response #17947

merged 1 commit into from
Nov 2, 2023

Conversation

ghalliday
Copy link
Member

@ghalliday ghalliday commented Oct 24, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@ghalliday
Copy link
Member Author

Changes to the tagging scripts to update the timestamp will be released separately

@afishbeck afishbeck self-requested a review October 24, 2023 13:34
afishbeck
afishbeck reviewed Oct 24, 2023
View reviewed changes
esp/scm/ws_workunits_req_resp.ecm Outdated
@@ -936,6 +936,7 @@ ESPresponse [exceptions_inline] WUCreateZAPInfoResponse

ESPrequest [nil_remove] WUCheckFeaturesRequest
{
boolean IncludeFullVersion;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably default this to false.

boolean IncludeFullVersion(false);

afishbeck
afishbeck reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@afishbeck afishbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday one comment.

@github-actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30610
Jira updated

@ghalliday ghalliday requested a review from afishbeck October 24, 2023 15:10
@ghalliday
Copy link
Member Author

This also needs a similar change in LN to introduce the new field in the version file.

@ghalliday
Copy link
Member Author

https://github.com/hpcc-systems/LN/pull/1030

GordonSmith
GordonSmith approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just one question over the default date/time

version.cmake Outdated
@@ -8,4 +8,5 @@ set ( HPCC_MINOR 12 )
set ( HPCC_POINT 65 )
set ( HPCC_MATURITY "closedown" )
set ( HPCC_SEQUENCE 0 )
set ( HPCC_TAG_TIMESTAMP "2023-01-01T01:00:00Z" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the Linux epoch time?

@ghalliday
HPCC-30610 Include the tagging timestamp in the WUCheckFeatures response
8a0c01e 
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@ghalliday ghalliday merged commit 646eb31 into hpcc-systems:candidate-8.12.x Nov 2, 2023
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

@afishbeck afishbeck afishbeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghalliday @afishbeck @GordonSmith