Skip to content

Commit

Permalink
HPCC-30795 Code review 2
Browse files Browse the repository at this point in the history
- Abandons in mem ca cert support
- Adds ca cert path support
- Fixes README file format

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
  • Loading branch information
rpastrana committed Nov 15, 2023
1 parent c1979f1 commit ba7c055
Showing 2 changed files with 7 additions and 6 deletions.
7 changes: 4 additions & 3 deletions helm/examples/tracing/README.md
Original file line number Diff line number Diff line change
@@ -18,8 +18,8 @@ All configuration options detailed here are part of the HPCC Systems Helm chart,
- consoleDebug - (default false)
- OTLP-GRCP
- endpoint: (default localhost:4317) The endpoint to export to. By default the OpenTelemetry Collector's default endpoint.
- useSslCredentials - By default when false, uses grpc::InsecureChannelCredentials; If true uses sslCredentialsCACcert
- sslCredentialsCACcert - String representation of .pem file to be used for SSL encryption.
- useSslCredentials - By default when false, uses grpc::InsecureChannelCredentials; If true uses sslCredentialsCACertPath
- sslCredentialsCACertPath - Path to .pem file to be used for SSL encryption.
- timeOutSeconds - (default 10secs) Timeout for grpc deadline
- processor - Controls span processing style. One by one as available, or in batches.
- type - (default: simple) "simple" | "batch"
@@ -88,7 +88,8 @@ Sample exported span data:
},
"InstrumentedLibrary":"esp"

}```
}
```

## Directory Contents

6 changes: 3 additions & 3 deletions system/jlib/jtrace.cpp
Original file line number Diff line number Diff line change
@@ -796,9 +796,9 @@ class CTraceManager : implements ITraceManager, public CInterface

if (opts.use_ssl_credentials)
{
StringBuffer sslCACert;
exportConfig->getProp("@sslCredentialsCACcert", sslCACert);
opts.ssl_credentials_cacert_as_string = sslCACert.str();
StringBuffer sslCACertPath;
exportConfig->getProp("@sslCredentialsCACertPath", sslCACertPath);
opts.ssl_credentials_cacert_path = sslCACertPath.str();
}

if (exportConfig->hasProp("@timeOutSecs")) //grpc deadline timeout in seconds

0 comments on commit ba7c055

Please sign in to comment.