HPCC-30687 Code review1

- Defines otel attribute names for globalid, and callerid - No unittest since no exporter available to test locally Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexisrisk.com>
hpcc-systems · Nov 9, 2023 · 67acc6f · 67acc6f
1 parent 2fa1c36
commit 67acc6f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/system/jlib/jtrace.cpp b/system/jlib/jtrace.cpp
@@ -658,10 +658,10 @@ class CServerSpan : public CSpan
     void setContextAttributes()
     {
         if (!isEmptyString(hpccGlobalId))
-            setSpanAttribute(kGlobalIdHttpHeaderName, hpccGlobalId.get());
+            setSpanAttribute(kGlobalIdOtelAttributeName, hpccGlobalId.get());
 
         if (!isEmptyString(hpccCallerId))
-            setSpanAttribute(kCallerIdHttpHeaderName, hpccCallerId.get());
+            setSpanAttribute(kCallerIdOtelAttributeName, hpccCallerId.get());
     }
 
 public:

diff --git a/system/jlib/jtrace.hpp b/system/jlib/jtrace.hpp
@@ -27,6 +27,8 @@ static constexpr const char *kGlobalIdHttpHeaderName = "Global-Id";
 static constexpr const char *kCallerIdHttpHeaderName = "Caller-Id";
 static constexpr const char *kLegacyGlobalIdHttpHeaderName = "HPCC-Global-Id";
 static constexpr const char *kLegacyCallerIdHttpHeaderName = "HPCC-Caller-Id";
+static constexpr const char *kGlobalIdOtelAttributeName = "hpcc.globalid";
+static constexpr const char *kCallerIdOtelAttributeName = "hpcc.callerid";
 
 enum class SpanFlags : unsigned
 {