Update based on review comments.

hpcc-systems · Oct 22, 2024 · 60ad141 · 60ad141
1 parent 3f1402e
commit 60ad141
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/system/globalid/lnuid.cpp b/system/globalid/lnuid.cpp
@@ -96,14 +96,7 @@ namespace ln_uid {
         {
             // Should never happen, but if it does log it and fallback
             OERRLOG("Could not read data from /dev/urandom");
-            auto randchar = []() -> char {
-                const char charset[] = "0123456789"
-                                    "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
-                                    "abcdefghijklmnopqrstuvwxyz";
-                const size_t max_index = (sizeof(charset) - 1);
-                return charset[static_cast<size_t>(rand()) % max_index];
-            };
-            std::generate_n(randomdata, random_byte_count, randchar);
+            std::generate_n(randomdata, random_byte_count, [](){ return char(rand()); });
         }
         if (fp)
             fclose(fp);