Merge pull request #19075 from ghalliday/issue32598

HPCC-32598 Fix build break caused by -Werror=implicit-fallthrough Reviewed-By: Attila Vamos <attila.vamos@gmail.com> Reviewed-By: Richard Chapman <rchapman@hpccsystems.com> Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
hpcc-systems · Sep 5, 2024 · 5aef331 · 5aef331
2 parents 8372412 + a71adf6
commit 5aef331
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/remote/rmtsmtp.cpp b/common/remote/rmtsmtp.cpp
@@ -280,7 +280,7 @@ class CSMTPValidator
         return ret;
     }
 
-    void fail(char const * msg)
+    [[noreturn]] void fail(char const * msg)
     {
         throw MakeStringException(0, "bad %s (%s at character %u): %s", label, msg, (unsigned) (finger-value), value);
     }

diff --git a/common/remote/rmtssh.cpp b/common/remote/rmtssh.cpp
@@ -257,7 +257,7 @@ class CFRunSSH: public CInterface, implements IFRunSSH
                             password.set(parm);
                             break;
                         }
-                        // continue
+                        [[fallthrough]];
                     default:
                         throw MakeStringException(-1,"Unknown option %s",argv[i]);
                 }