HPCC-31416 Changes following review

Signed-off-by: Shamser Ahmed <shamser.ahmed@lexisnexis.com>
hpcc-systems · Mar 18, 2024 · 2324ef5 · 2324ef5
1 parent 4072317
commit 2324ef5
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/dali/base/dadfs.cpp b/dali/base/dadfs.cpp
@@ -6274,10 +6274,12 @@ class CDistributedSuperFile: public CDistributedFileBase<IDistributedSuperFile>
         if (sub)
         {
             unsigned subfilen = idx;
-            ForEachItemIn(i,subfiles) {
+            ForEachItemIn(i,subfiles)
+            {
                 IDistributedFile &f=subfiles.item(i);
                 IDistributedSuperFile *super = f.querySuperFile();
-                if (super) {
+                if (super)
+                {
                     unsigned ns = super->numSubFiles(true);
                     if (ns>subfilen)
                         return super->querySubFile(subfilen,true);
@@ -6288,7 +6290,8 @@ class CDistributedSuperFile: public CDistributedFileBase<IDistributedSuperFile>
             }
             throw makeStringExceptionV(-1,"CDistributedSuperFile::querySubFile(%u) for superfile %s - subfile doesn't exist ", idx, logicalName.get());
         }
-        return subfiles.item(idx);
+        else
+            return subfiles.item(idx);
     }
 
     virtual IDistributedFile *querySubFileNamed(const char *name, bool sub) override