Skip to content

Commit

Permalink
Merge pull request #18183 from ghalliday/issue31063
Browse files Browse the repository at this point in the history
HPCC-31063 Improve the error message when failing to connect to a host ip

Reviewed-by: Mark Kelly mark.kelly@lexisnexisrisk.com
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>
  • Loading branch information
ghalliday authored Jan 10, 2024
2 parents f68fd84 + 15f256c commit 1a88724
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions common/thorhelper/thorsoapcall.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2407,6 +2407,9 @@ class CWSCAsyncFor : implements IWSCAsyncFor, public CInterface, public CAsyncFo
checkTimeLimitExceeded(&remainingMS);
Url &connUrl = master->proxyUrlArray.empty() ? url : master->proxyUrlArray.item(0);
ep.set(connUrl.host.get(), connUrl.port);
if (ep.isNull())
throw MakeStringException(-1, "Failed to resolve host '%s'", nullText(connUrl.host.get()));

checkTimeLimitExceeded(&remainingMS); // after ep.set which might make a potentially long getaddrinfo lookup ...
if (strieq(url.method, "https"))
proto = PersistentProtocol::ProtoTLS;
Expand Down

0 comments on commit 1a88724

Please sign in to comment.