refactor: Refactor LagrangeMultiplier constructor to initialize m_S_V…

…ector efficiently
hpc-maths · Oct 2, 2024 · a8ec7c9 · a8ec7c9
1 parent 3596abb
commit a8ec7c9
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/include/scopi/solvers/lagrange_multiplier.hpp b/include/scopi/solvers/lagrange_multiplier.hpp
@@ -53,10 +53,10 @@ namespace scopi
 
         LagrangeMultiplier(const Contacts& contacts, double)
             : base(contacts)
+            , m_S_Vector(xt::zeros<double>({contacts.size()}))
+            , m_local_work(xt::zeros<double>({contacts.size()}))
+            , m_global_work(xt::zeros<double>({3 * contacts.size()}))
         {
-            m_S_Vector    = xt::zeros<double>({size()});
-            m_local_work  = xt::zeros<double>({size()});
-            m_global_work = xt::zeros<double>({3 * contacts.size()});
         }
 
         const auto& global2local(const xt::xtensor<double, 1>& x) const
@@ -216,8 +216,8 @@ namespace scopi
 
         LagrangeMultiplier(const Contacts& contacts, double)
             : base(contacts)
+            , m_S_Vector(xt::zeros<double>({contacts.size()}))
         {
-            m_S_Vector = xt::zeros<double>({size()});
         }
 
         auto global2local(const xt::xtensor<double, 1>& x) const
@@ -284,8 +284,8 @@ namespace scopi
 
         LagrangeMultiplier(const Contacts& contacts, [[maybe_unused]] double dt)
             : base(contacts)
+            , m_S_Vector(xt::zeros<double>({contacts.size()}))
         {
-            m_S_Vector = xt::zeros<double>({size()});
             for (std::size_t i = 0, row = 0; i < this->m_contacts.size(); ++i, row += 3)
             {
                 xt::view(m_S_Vector, xt::range(row, row + dim)) = this->m_contacts[i].sij * this->m_contacts[i].nij;
@@ -356,6 +356,7 @@ namespace scopi
 
         LagrangeMultiplier(const Contacts& contacts, double dt) // cppcheck-suppress uninitMemberVar
             : base(contacts)
+            , m_S_Vector(xt::zeros<double>({contacts.size()}))
         {
             m_size = 0;
             for (std::size_t i = 0; i < this->m_contacts.size(); ++i)
@@ -376,7 +377,7 @@ namespace scopi
                     ++m_size;
                 }
             }
-            m_S_Vector      = xt::zeros<double>({size()});
+
             std::size_t row = 0;
             for (std::size_t i = 0; i < this->m_contacts.size(); ++i)
             {