Implemented: documentation of DxpShopifyImg, DxpProductIdentifier and DxpMenuFooterNavigation for user reference #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DxpMenuFooterNavigation for user reference
dt2patel
requested changes
Feb 15, 2024
There was a problem hiding this comment.
@amansinghbais kind of some side questions. Please take a look
|
|
||
| <h4> Conditions </h4> | ||
|
|
||
| * Allows product stores selection only when there are multiple stores to choose from. (i.e., more than 2) |
There was a problem hiding this comment.
should me more than 1 right?
| * Allows product stores selection only when there are multiple stores to choose from. (i.e., more than 2) | ||
| * Allows shopify configs selection only if both the given below conditions fulfill: | ||
| * More than 1 shopify configs are availabe | ||
| * And less than 3 product stores are available |
dt2patel
requested changes
Feb 15, 2024
| import { DxpShopifyImg } from '@hotwax/dxp-components'; | ||
| </script> | ||
|
|
||
| ### Props |
There was a problem hiding this comment.
Check the table pattern followed by @Ritika-Patel08 and use that as a standard.
|
|
||
| ### Recommendation | ||
|
|
||
| This component can be used anywhere for displaying image just need to pass image src as prop and optional to pass size. |
There was a problem hiding this comment.
we can add a link to Shopify doc of image sizes
| <h4> Conditions </h4> | ||
|
|
||
| * Allows product stores selection only when there are multiple stores to choose from. (i.e., more than 2) | ||
| * Allows shopify configs selection only if both the given below conditions fulfill: |
There was a problem hiding this comment.
Suggested change
| * Allows shopify configs selection only if both the given below conditions fulfill: | |
| * Allows Shopify configs selection only if both the given below conditions fulfill: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.