-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented: Clean up UI for BOPIS inventory lookup (#470) #509
Open
ashutosh7i
wants to merge
13
commits into
hotwax:main
Choose a base branch
from
ashutosh7i:470
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+390
−28
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c94c501
Implented: Step1- fetching current facility lat-lon from facilityId.
ashutosh7i a285f0a
Fixed: step1 showing lat-long in card, bugfixes.
ashutosh7i 8e64289
Implemented : Step 2- fetching stores using lat-lon to obtain distanc…
ashutosh7i b0d620e
Implemented: Step 3- atp + storeLookup data in new array,
ashutosh7i 155f26c
Implemented: Step 4 : all features implemented.
ashutosh7i 1b81790
Implemented: Clean up UI for BOPIS inventory lookup (#470)
ashutosh7i f43466e
Improved: created a new branch with issue-number, added internalizati…
ashutosh7i bd015e1
Improved: code improvements after review, including stores with infin…
ashutosh7i feda473
Improved: variable meaningful names, searchbar debounced search, ion-…
ashutosh7i 8111c68
Improved: updated state name fetchCurrentFacilityInformation to fetch…
ashutosh7i f7910b4
Improved: code formatting.
ashutosh7i bb2e574
Improved: Instead of passing facilityId from props, directly fetching…
ashutosh7i dad0c7c
Improved: facilityLatLon state updates. (#470)
ashutosh7i File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -27,5 +27,11 @@ const getters: GetterTree <UtilState, RootState> = { | |||||||||||||
getEnumDescription: (state) => (enumId: string) => { | ||||||||||||||
return state.enumerations[enumId] ? state.enumerations[enumId] : enumId | ||||||||||||||
}, | ||||||||||||||
getCurrentFacilityLatLon: (state) => { | ||||||||||||||
return state.facilitiesLatLng ? state.facilitiesLatLng : {} | ||||||||||||||
}, | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
getStoresInformation: (state) => { | ||||||||||||||
return state.storesInformation ? state.storesInformation : [] | ||||||||||||||
} | ||||||||||||||
} | ||||||||||||||
export default getters; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -7,3 +7,5 @@ export const UTIL_PARTY_NAMES_UPDATED = SN_UTIL + '/PARTY_NAMES_UPDATED' | |||||
export const UTIL_CANCEL_REASONS_UPDATED = SN_UTIL + '/CANCEL_REASONS_UPDATED' | ||||||
export const UTIL_FACILITIES_UPDATED = SN_UTIL + '/FACILITIES_UPDATED' | ||||||
export const UTIL_ENUMERATIONS_UPDATED = SN_UTIL + '/ENUMERATIONS_UPDATED' | ||||||
export const UTIL_CURRENT_FACILITY_LAT_LON_UPDATED = SN_UTIL + '/CURRENT_FACILITY_LAT_LON_UPDATED' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
export const UTIL_STORES_INFORMATION_UPDATED = SN_UTIL + '/STORES_INFORMATION_UPDATED' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -27,5 +27,11 @@ const mutations: MutationTree <UtilState> = { | |||||
[types.UTIL_ENUMERATIONS_UPDATED] (state, payload) { | ||||||
state.enumerations = payload | ||||||
}, | ||||||
[types.UTIL_CURRENT_FACILITY_LAT_LON_UPDATED] (state, payload) { | ||||||
state.facilitiesLatLng = payload | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}, | ||||||
[types.UTIL_STORES_INFORMATION_UPDATED] (state, payload) { | ||||||
state.storesInformation = payload | ||||||
} | ||||||
} | ||||||
export default mutations; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.