From 2a81bdfa4424c84edb8b57434c31e5fb5bb269c8 Mon Sep 17 00:00:00 2001 From: Anuj Gupta <84966248+Anuj-Gupta4@users.noreply.github.com> Date: Wed, 22 Jan 2025 17:02:15 +0545 Subject: [PATCH] fix(backend): review state for received on submission table (#2101) * fix(submission): fix review state filter for received * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --- src/backend/app/submissions/submission_routes.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/backend/app/submissions/submission_routes.py b/src/backend/app/submissions/submission_routes.py index f9494276e..a297f560f 100644 --- a/src/backend/app/submissions/submission_routes.py +++ b/src/backend/app/submissions/submission_routes.py @@ -303,7 +303,7 @@ async def submission_table( "and __system/submissionDate le {}T23:59:59.999+00:00" ).format(start_date, end_date) - if review_state: + if review_state and review_state != "received": review_filter = f"__system/reviewState eq '{review_state}'" filters["$filter"] = ( f"{filters['$filter']} and {review_filter}" @@ -314,6 +314,12 @@ async def submission_table( data = await submission_crud.get_submission_by_project(project, filters) total_count = data.get("@odata.count", 0) submissions = data.get("value", []) + if review_state == "received": + submissions = [ + sub for sub in submissions if sub["__system"].get("reviewState") is None + ] + total_count = len(submissions) + instance_ids = [ sub["__id"] for sub in submissions