Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoodieObjectIdError message doesn't explain ID naming restriction #427

Closed
skibz opened this issue Jul 15, 2015 · 2 comments
Closed

HoodieObjectIdError message doesn't explain ID naming restriction #427

skibz opened this issue Jul 15, 2015 · 2 comments

Comments

@skibz
Copy link

skibz commented Jul 15, 2015

example:

hoodie.store.findOrAdd(
    'account',
    'abc@123.com', 
    {id:'abc@123.com', abc: 123}
).done(
    console.log.bind(console)
).fail(
    console.error.bind(console)
);

results in:

HoodieError {
    id: "abc@123.com",
    name: "HoodieObjectIdError",
    message: "'abc@123.com' is invalid object id. undefined."
}

HoodieError.message should also contain:

@ or . characters are disallowed.

@gr2m
Copy link
Member

gr2m commented Jul 15, 2015

Thanks @skibz, that's a good one! I'll leave it open for reference for the implementation of the new hoodie.store API

@gr2m
Copy link
Member

gr2m commented Sep 18, 2015

closing in favor of hoodiehq/pouchdb-hoodie-api#80

@gr2m gr2m closed this as completed Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants