Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Object.entries is called with a null value #211

Closed
wants to merge 1 commit into from
Closed

fix: Object.entries is called with a null value #211

wants to merge 1 commit into from

Conversation

mjad218
Copy link
Contributor

@mjad218 mjad218 commented Oct 31, 2024

A small change to the same function.
I am using hono with Nest.js and somehow buildOutgoingHttpHeaders is called with a null argument.

I have updated the function to address this edge case.

@yusukebe
Copy link
Member

yusukebe commented Nov 4, 2024

Hi @mjad218

The PR #212 is merged. So, is this change unnecessary?

@mjad218
Copy link
Contributor Author

mjad218 commented Nov 4, 2024

@yusukebe
No this should be closed.

@mjad218 mjad218 closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjad218 @yusukebe