Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Auto Zen mode" setting #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yanzay
Copy link

@yanzay yanzay commented Aug 28, 2024

Add setting "Auto Zen mode" and go to Zen mode automatically when joining the game:
Simulator Screen Recording - iPhone 15 Pro - 2024-08-28 at 15 03 21

@yanzay yanzay changed the title Add "Auto Zen mode" setting. Add "Auto Zen mode" setting Aug 28, 2024
@honganhkhoa
Copy link
Owner

The commit looks good, but the way this feature is implemented feels off to me: if someone wants to use Zen mode everytime, instead of having to activate Zen mode every time, now they have to deactivate it every time in order to exit the view.

I think a better way to implement this would be to add a "Back" button to the Zen mode view, and if someone exits the view with that button (without deactivating Zen mode) then it automatically opens game with Zen mode next time. That way we can also avoid adding another setting (I have been trying to avoid having too many settings).

Is it your personal preference to always play with Zen mode? Let me know what you think.

Thanks.

@honganhkhoa
Copy link
Owner

if someone wants to use Zen mode everytime, instead of having to activate Zen mode every time, now they have to deactivate it every time in order to exit the view.

Sorry this is inaccurate, because as it is now we still have to deactivate Zen mode every time. Still, I think it's better if we can implement it in a way that can remove the need of both activating and deactivating Zen mode if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants