Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide pause reason from timer when game is finished, not paused #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hide pause reason from timer when game is finished, not paused #17

wants to merge 1 commit into from

Conversation

yanzay
Copy link

@yanzay yanzay commented Aug 28, 2024 •
edited
Loading

Instead of showing "Stone removal" on finished games:
Screenshot 2024-08-28 at 12 57 19
Screenshot 2024-08-28 at 12 57 07

honganhkhoa
honganhkhoa reviewed Sep 1, 2024
View reviewed changes
Copy link
Owner

@honganhkhoa honganhkhoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it simpler to just use the timer with showsPauseReson: game.gamePhase != .finished? That way we don't need to add another state and additional logic to the timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honganhkhoa honganhkhoa honganhkhoa left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanzay @honganhkhoa