feat(buildevents): make honeycomb api host optionally configurable #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookesargent
changed the title
brookesargent
force-pushed
the
brooke.configurable-api-host
branch
from
2e48f9d to
266b420
Compare
cewkrupa
reviewed
Nov 28, 2023
cewkrupa
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
https://app.asana.com/0/1198607545155957/1204760277025814/f
Short description of the changes
Allows api host to be optionally configured for EU or Secure Tenancy customers
How to verify that this has the expected result
I created a team in EU and then updated my fork of
microservices-testing-examplesto send to that team with the new host configuration. Then I validated the GitHub Action data made it there, it did!