Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HassListCompleteItem #3004

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

michael-genson
Copy link

@michael-genson michael-genson commented Feb 19, 2025

Adds "remove" "complete" intents for todo lists. See core PR:

Previously this also had the shopping list complete item intents, but I've moved those to another PR

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michael-genson

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 19, 2025 22:54
@michael-genson michael-genson marked this pull request as ready for review February 19, 2025 22:55
@tetele
Copy link
Contributor

tetele commented Feb 20, 2025

Thank you, but such new functionality requires a corresponding PR in core. Do you know of any such PR and can you link it here? It's great to see you have marked the intents as not supported, at least

@michael-genson
Copy link
Author

Ah yep, makes sense. I wasn't sure if I needed to get this in first (as not supported) then get it in core, or vice versa, or simultaneously. I can get a PR open there in the next day or two and link it here.

@tetele
Copy link
Contributor

tetele commented Feb 20, 2025

Sounds great! Please cross link the PRs once you do.

@michael-genson
Copy link
Author

Turns out someone is already working on this in core:

I've renamed to "complete" (rather than remove) since that's the verbiage in the core PR (and it works better than remove anyway since other internals use the same terminology)

@michael-genson michael-genson changed the title feat: Add HassListRemoveItem and HassShoppingListRemoveItem feat: Add HassListCompleteItem and HassShoppingListCompleteItem Feb 21, 2025
@Lesekater
Copy link

Lesekater commented Mar 4, 2025

Turns out someone is already working on this in core:

I've renamed to "complete" (rather than remove) since that's the verbiage in the core PR (and it works better than remove anyway since other internals use the same terminology)

FIY - home-assistant/core#127806 just got merged into dev. You might wanna split up this PR, so HassListCompleteItem can get merged without having to wait on home-assistant/core#128565.

@michael-genson michael-genson changed the title feat: Add HassListCompleteItem and HassShoppingListCompleteItem feat: Add HassListCompleteItem Mar 5, 2025
@michael-genson
Copy link
Author

michael-genson commented Mar 5, 2025

Thanks! Will do

See: #3035

@synesthesiam synesthesiam self-assigned this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants