-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add HassListCompleteItem #3004
base: main
Are you sure you want to change the base?
feat: Add HassListCompleteItem #3004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thank you, but such new functionality requires a corresponding PR in core. Do you know of any such PR and can you link it here? It's great to see you have marked the intents as not supported, at least |
Ah yep, makes sense. I wasn't sure if I needed to get this in first (as not supported) then get it in core, or vice versa, or simultaneously. I can get a PR open there in the next day or two and link it here. |
Sounds great! Please cross link the PRs once you do. |
Turns out someone is already working on this in core:
I've renamed to "complete" (rather than remove) since that's the verbiage in the core PR (and it works better than remove anyway since other internals use the same terminology) |
FIY - home-assistant/core#127806 just got merged into dev. You might wanna split up this PR, so HassListCompleteItem can get merged without having to wait on home-assistant/core#128565. |
Thanks! Will do See: #3035 |
Adds
"remove""complete" intents for todo lists. See core PR:Previously this also had the shopping list complete item intents, but I've moved those to another PR