-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ring docs for in-home chime switch #35123
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough📝 WalkthroughWalkthroughThe changes made in this pull request update the documentation for the Ring integration in Home Assistant. Key updates include the addition of "Event" and "Siren" entities, replacing existing binary sensors and volume sensors with new functionalities. The documentation also outlines the migration paths for users transitioning to these new entities and clarifies the updated capabilities of the switch platform, particularly regarding motion detection and chimes. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
source/_integrations/ring.markdown (2)
44-46
: LGTM: Binary sensor deprecation noticeThe added note about the binary sensor being replaced with the event entity is crucial information for users. It aligns with the PR objectives to update documentation for new features.
Consider adding a brief explanation of how to migrate automations from binary sensors to event entities. This could help users prepare for the transition before the 2025.4.0 release.
164-168
: LGTM: New Event entity sectionThe addition of the Event entity section is excellent and provides crucial information about the new functionality. The subsection on realtime event stability is particularly helpful for troubleshooting.
Consider adding an example of how to use the Event entity in an automation. This could help users understand how to migrate from binary sensors to events more effectively.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~166-~166: Possible missing comma found.
Context: ...for every camera that supports a siren. Note the siren will only turn on for 30 seco...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- source/_integrations/ring.markdown (2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/ring.markdown
[uncategorized] ~166-~166: Possible missing comma found.
Context: ...for every camera that supports a siren. Note the siren will only turn on for 30 seco...(AI_HYDRA_LEO_MISSING_COMMA)
🪛 Markdownlint
source/_integrations/ring.markdown
174-174: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
🔇 Additional comments (1)
source/_integrations/ring.markdown (1)
Line range hint
1-43
: LGTM: Updated supported device typesThe changes in the file header and supported device types list accurately reflect the addition of new "Event" and "Siren" entities. This update aligns with the PR objectives to document new features introduced in Core version 2024.10.0.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
source/_integrations/ring.markdown (2)
Line range hint
51-53
: LGTM: Clear migration information for binary sensorsThe addition of information about replacing binary sensors with event entities is valuable and aligns with the integration updates. The migration timeline is clearly stated, which is helpful for users.
Consider adding a brief explanation of the benefits of this change to help users understand why they should migrate their automations.
164-168
: LGTM: New Event entity section with minor suggestionThe addition of the Event entity section is valuable and aligns with the PR objectives. It provides important information about the new functionality.
Consider adding a comma in line 166 for improved readability:
-- Adds a siren entity for every camera that supports a siren. Note the siren will only turn on for 30 seconds before automatically turning off. ++ Adds a siren entity for every camera that supports a siren. Note, the siren will only turn on for 30 seconds before automatically turning off.🧰 Tools
🪛 LanguageTool
[uncategorized] ~166-~166: Possible missing comma found.
Context: ...for every camera that supports a siren. Note the siren will only turn on for 30 seco...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- source/_integrations/ring.markdown (2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/ring.markdown
[uncategorized] ~166-~166: Possible missing comma found.
Context: ...for every camera that supports a siren. Note the siren will only turn on for 30 seco...(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (2)
source/_integrations/ring.markdown (2)
44-46
: LGTM: Added new supported device typesThe addition of "Event" and "Siren" to the list of supported device types accurately reflects the new functionalities introduced in the Ring integration. This update aligns well with the PR objectives and provides users with a clear overview of the available features.
171-174
: LGTM: Updated Switch section with new functionalitiesThe updates to the Switch section, including motion detection and in-home chime controls, provide valuable information about new control options for users. This aligns well with the PR objectives to document new features.
The previously mentioned trailing space issue has been resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sdb9696 👍
../Frenck
Proposed change
Update ring docs for info about new in-home chime switch and the siren entities.
Addresses #35026
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation