Revert "Update AEMET-OpenData to v0.4.6"

[afharo]

Proposed change

Reverts #102996

It looks like that version of the package introduced a few regressions in 2023.12 (#105168, #105305), making the integration unusable.

There is a fix pending review Noltari/AEMET-OpenData#7, but, based on this comment, it looks like the review may take a while.

I think it'd be wise to revert for now and we'll upgrade to the appropriate version once the fixes are in place.

cc @Noltari as the original author of the reverted PR.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue: AEMET Unexpected error fetching aemet data: 'Station' object has no attribute 'dew_point' #105168, AEMET Integration AttributeError: 'Station' object has no attribute 'pressure' #105305, Update AEMET-OpenData to v0.4.6 #102996
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hi @afharo

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[home-assistant]

Hey there @Noltari, mind taking a look at this pull request as it has been labeled with an integration (aemet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of aemet can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign aemet Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[joostlek]

Let's get this PR ready (please fill in the form). Noltari said it will take him a few days, 2023.12.3 will probably be released before the weekend. If it isn't merged and released by them we can merge this

Stale

[joostlek]

Please fill in the PR template. since you probably clicked revert in github, please checkout https://github.com/home-assistant/core/blob/dev/.github/PULL_REQUEST_TEMPLATE.md and copy the stuff to this description

[afharo]

Digging further, I noticed the bug was introduced in version 0.4.4 of the package. This means we should downgrade to 0.4.3, meaning reverting #100818 and #99418.

Bearing in mind the bump to 0.4.4 fixed #99406, I don't think reverting is the solution.

I'll close this PR and hope for Noltari/AEMET-OpenData#7 to be merged and released soon. Apologies for the noise in this PR, and thanks to @joostlek for guiding me through the process of submitting my first PR to HASS.

[joostlek]

I mean at least we now did a little research that this isn't the solution (and that we didn't merge this directly)