bug: OMV System Health Monitoring: Invalid temperature value

[JureFabjan]

Describe the bug

I am running Homarr on my NAS with OpenMediaVault installed. I have installed openmediavault-cputemp 7.0.2 and am trying to get data to show on System Health Monitoring. There I get "Failed to fetch health status" and the logs tell me that the temperature has an invalid value. I tried to uncheck the variables that are being fetched in the widget customization, with no result.

Steps to reproduce

Add openmediavault-cputemp 7.0.2 to the OMV, add OMV integration to Homarr and add the System Health Monitoring widget to the board.

Impact

I am unaware of a workaround. I have tried the fixes to CPU temperature bug available on GitHub repos and elsewhere, but these did not resolve the issue.

Additional information

2025-02-13T13:24:58.772Z error Failed to run integration job integration=jidn8wr697vrxlz0tn9fc2z9 inputHash='W3t9XQ==' error=Error: Invalid temperature value
at Object.transform (/app/apps/tasks/tasks.cjs:458798:17)
at ZodEffects._parse (/app/apps/tasks/tasks.cjs:23688:35)
at _ZodObject._parse (/app/apps/tasks/tasks.cjs:22465:33)
at _ZodObject._parseSync (/app/apps/tasks/tasks.cjs:20835:29)
at /app/apps/tasks/tasks.cjs:22385:27
at Array.map ()
at _ZodArray._parse (/app/apps/tasks/tasks.cjs:22384:38)
at _ZodObject._parse (/app/apps/tasks/tasks.cjs:22465:33)
at _ZodObject._parseSync (/app/apps/tasks/tasks.cjs:20835:29)
at _ZodObject.safeParse (/app/apps/tasks/tasks.cjs:20865:29)

Version

1.5.0

Installation method

Docker Run

Browser

Firefox

[Meierschlumpf]

This issue is similar to #2145 that was fixed in #2247, but it seems like there is another temperature for smart, see the following code:

// Schema for SMART information
export const smartSchema = z.object({
  response: z.array(
    z.object({
      devicename: z.string(),
      temperature: z.union([z.string(), z.number()]).transform((val) => {
        // Convert string to number if necessary
        const temp = typeof val === "string" ? parseFloat(val) : val;
        if (isNaN(temp)) {
          throw new Error("Invalid temperature value");
        }
        return temp;
      }),
      overallstatus: z.string(),
    }),
  ),
});

This code has probably also to be adjusted to allow undefined

[manuel-rw]

Can you please check whether we solved this issue in the test image https://github.com/homarr-labs/homarr/pkgs/container/homarr/356023907?tag=fix-omv-invalid-temperature-when-not-available ?
Please don't forget to backup your instance first and restore your previous image, since this is only a temporary testing image and will be deleted later on.

[JureFabjan]

The image works. It shows 0C for the temperature for the drives, but it does read the temperature of the CPU. The other values are correct.

[manuel-rw]

I assume you also don't see any temp in OMV? Homarr simply crashed because OMV didn't return any temperature for them.
If this is correct, I will merge the PR and the fix will be available in the next deployment.

[JureFabjan]

I am still trying to understand why this happens. OMV tells me the temperatures for the drives. I am running a main NVME drive and some HDDs in RAID for storage. But Homarr reports temperatures for the two partitions instead of the drives themselves. I am not sure if this is a problem of what data Homarr tries to fetch or what OMV is returning.