koinly cointracking: added csv row support for realized_pnl

hodgerpodger · Feb 25, 2025 · 81d0587 · 81d0587
1 parent 2208c5a
commit 81d0587
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 27 deletions.
diff --git a/src/staketaxcsv/common/Exporter.py b/src/staketaxcsv/common/Exporter.py
@@ -179,38 +179,46 @@ def _rows_export(self, csv_format, reverse=True, export_all=False):
             # custom behavior: exports rows with tx_type=_* (.i.e _UNKNOWN)
             rows = self.rows
         else:
-            rows = filter(lambda row: row.tx_type in et.TX_TYPES_CSVEXPORT, self.rows)
+            allowed_types = list(et.TX_TYPES_CSVEXPORT)
+
+            # List of csv formats that support REALIZED_PNL
+            if csv_format in [et.FORMAT_KOINLY, et.FORMAT_COINTRACKING]:
+                allowed_types.append(et.TX_TYPE_REALIZED_PNL)
+
+            # Filter rows based on the allowed tx types.
+            rows = filter(lambda row: row.tx_type in allowed_types, self.rows)
 
         if csv_format in [et.FORMAT_COINTRACKING, et.FORMAT_COINPANDA, et.FORMAT_COINTELLI,
                           et.FORMAT_DIVLY, et.FORMAT_CRYPTOBOOKS, et.FORMAT_KOINLY]:
+            # CSV formats that support LP_DEPOSIT/LP_WITHDRAW
             return rows
-
-        # For non-koinly CSVs, convert LP_DEPOSIT/LP_WITHDRAW into transfers/omit/trades
-        # (due to lack of native csv import support)
-        out = []
-        for row in rows:
-            if row.tx_type == et.TX_TYPE_LP_DEPOSIT:
-                if self.lp_treatment == et.LP_TREATMENT_OMIT:
-                    continue
-                elif self.lp_treatment == et.LP_TREATMENT_TRANSFERS:
-                    out.append(self._row_as_transfer_out(row))
-                elif self.lp_treatment == et.LP_TREATMENT_TRADES:
-                    out.append(self._row_as_trade(row))
-                else:
-                    raise Exception("Bad condition in _rows_export().  lp_treatment=%s".format(self.lp_treatment))
-            elif row.tx_type == et.TX_TYPE_LP_WITHDRAW:
-                if self.lp_treatment == et.LP_TREATMENT_OMIT:
-                    continue
-                elif self.lp_treatment == et.LP_TREATMENT_TRANSFERS:
-                    out.append(self._row_as_transfer_in(row))
-                elif self.lp_treatment == et.LP_TREATMENT_TRADES:
-                    out.append(self._row_as_trade(row))
+        else:
+            # CSV formats that do not support LP_DEPOSIT/LP_WITHDRAW:
+            # Convert LP_DEPOSIT/LP_WITHDRAW into transfers/omit/trades
+            out = []
+            for row in rows:
+                if row.tx_type == et.TX_TYPE_LP_DEPOSIT:
+                    if self.lp_treatment == et.LP_TREATMENT_OMIT:
+                        continue
+                    elif self.lp_treatment == et.LP_TREATMENT_TRANSFERS:
+                        out.append(self._row_as_transfer_out(row))
+                    elif self.lp_treatment == et.LP_TREATMENT_TRADES:
+                        out.append(self._row_as_trade(row))
+                    else:
+                        raise Exception("Bad condition in _rows_export().  lp_treatment=%s".format(self.lp_treatment))
+                elif row.tx_type == et.TX_TYPE_LP_WITHDRAW:
+                    if self.lp_treatment == et.LP_TREATMENT_OMIT:
+                        continue
+                    elif self.lp_treatment == et.LP_TREATMENT_TRANSFERS:
+                        out.append(self._row_as_transfer_in(row))
+                    elif self.lp_treatment == et.LP_TREATMENT_TRADES:
+                        out.append(self._row_as_trade(row))
+                    else:
+                        raise Exception("Bad condition in _rows_export().  lp_treatment=%s".format(self.lp_treatment))
                 else:
-                    raise Exception("Bad condition in _rows_export().  lp_treatment=%s".format(self.lp_treatment))
-            else:
-                out.append(row)
+                    out.append(row)
 
-        return out
+            return out
 
     def _row_as_transfer_out(self, row):
         return Row(
@@ -428,6 +436,19 @@ def _cointracking_type(self, row):
         }
 
         # Determine type
+        ct_type = ""
+
+        if row.tx_type == et.TX_TYPE_REALIZED_PNL:
+            if row.received_amount and float(row.received_amount) > 0:
+                ct_type = "Derivatives / Futures Profit"
+            elif row.sent_amount and float(row.sent_amount) > 0:
+                ct_type = "Derivatives / Futures Loss"
+            else:
+                ct_type = "Derivatives / Futures Profit"
+                logging.error("Bad condition in export_cointracking_csv(): {}, {}, {}".format(
+                    row.received_amount, row.sent_amount, row.as_array()))
+            return ct_type
+
         ct_type = cointracking_types[row.tx_type]
         if ct_type == et.TX_TYPE_TRANSFER:
             if row.received_amount and not row.sent_amount:
@@ -921,6 +942,8 @@ def export_koinly_csv(self, csvpath):
                     label = "Liquidity In"
                 elif row.tx_type == et.TX_TYPE_LP_WITHDRAW:
                     label = "Liquidity Out"
+                elif row.tx_type == et.TX_TYPE_REALIZED_PNL:
+                    label = "realized gain"
                 else:
                     logging.error("koinly: unable to handle tx_type=%s", row.tx_type)
 

diff --git a/src/staketaxcsv/common/make_tx.py b/src/staketaxcsv/common/make_tx.py
@@ -192,7 +192,7 @@ def make_perp_pnl_tx(txinfo, net_gain_or_loss):
     if net_gain_or_loss >= 0:
         return _make_tx_exchange(txinfo, "", "", net_gain_or_loss, CUR_USD, TX_TYPE_REALIZED_PNL)
     elif net_gain_or_loss < 0:
-        return _make_tx_exchange(txinfo, -net_gain_or_loss, "", "", CUR_USD, TX_TYPE_REALIZED_PNL)
+        return _make_tx_exchange(txinfo, -net_gain_or_loss, CUR_USD, "", "", TX_TYPE_REALIZED_PNL)
 
 
 def _make_tx_received(txinfo, received_amount, received_currency, tx_type, txid=None, empty_fee=False, z_index=0):