[ALS-5911] Api Page, Refactor #11
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
JamesPeck
force-pushed
the
feature/api-page
branch
2 times, most recently
from
c926c3c to
62e880f
Compare
[ALS-5911] Api Page refactor
JamesPeck
force-pushed
the
feature/api-page
branch
from
62e880f to
ee45535
Compare
| }, | ||
| }; | ||
|
|
||
| export const domain = { |
There was a problem hiding this comment.
Not sure why this is here
|
|
||
| <div class="flex justify-between items-center"> | ||
| <span class="uuid">{data.cell}</span> | ||
| <CopyButton {buttonText} itemToCopy={data.cell} classes={buttonClasses} /> |
There was a problem hiding this comment.
Classes works fine here. I did see a 'style' that could allow you to do <CopyButton class={...} /> But it looks kinda weird. (I was going to use it to pass a style down to the ThSort component.)
<script lang="ts">
let clazz = '';
export { clazz as class };
...
</script>
<button class={`whatever ${clazz}`} />
There was a problem hiding this comment.
I am fine with this pattern if you want to do stuff like that. I don't feel very strongly either way. One difference is that I made it an array, and if we called it class I think it would need to just be a string.
| export interface User { | ||
| uuid?: string; | ||
| email?: string; | ||
| privileges?: string[]; |
There was a problem hiding this comment.
Is everything in this interface optional, or are there some things we can guarantee, like at least an empty privileges array?
There was a problem hiding this comment.
I made it all optional for now, I think this is something we should revisit when we do the true login.
No description provided.