Add Lint tests for PRs (#51)

hms-dbmi · Apr 29, 2024 · 845fdc5 · 845fdc5
1 parent 0552582
commit 845fdc5
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -18,6 +18,8 @@ jobs:
         run: npx playwright install --with-deps
       - name: Run Playwright tests
         run: npm test
+      - name: Run linting tests
+        run: npm run lint
       - uses: actions/upload-artifact@v4
         if: always()
         with:

diff --git a/src/lib/components/explorer/dataExport/ExportStepper.svelte b/src/lib/components/explorer/dataExport/ExportStepper.svelte
@@ -1,5 +1,4 @@
 <script lang="ts">
-  import type { SvelteComponent } from 'svelte';
   import { Step, Stepper, getModalStore } from '@skeletonlabs/skeleton';
 
   const modalStore = getModalStore();

diff --git a/src/lib/models/query/Query.ts b/src/lib/models/query/Query.ts
@@ -1,10 +1,11 @@
+import type { Indexable } from '$lib/types';
 type ExpectedResultType = 'COUNT' | 'CROSS_COUNT' | 'DATAFRAME';
 
 interface QueryInterface {
-  categoryFilters: Object; //TODO: define type
-  numericFilters: Object;
-  requiredFields: Object[];
-  anyRecordOf: Object[];
+  categoryFilters: object; //TODO: define type
+  numericFilters: object;
+  requiredFields: string[];
+  anyRecordOf: string[];
   variantInfoFilters: VariantInfoFilters[];
   expectedResultType: ExpectedResultType;
 }
@@ -25,10 +26,10 @@ interface VariantInfoFilters {
 }
 
 export class Query implements QueryInterface {
-  categoryFilters: Object;
-  numericFilters: Object;
-  requiredFields: Object[];
-  anyRecordOf: Object[];
+  categoryFilters: object;
+  numericFilters: object;
+  requiredFields: string[];
+  anyRecordOf: string[];
   variantInfoFilters: VariantInfoFilters[];
   expectedResultType: ExpectedResultType;
 
@@ -37,7 +38,7 @@ export class Query implements QueryInterface {
     this.numericFilters = {};
     this.requiredFields = [];
     this.anyRecordOf = [];
-    let variantInfoFilter = {
+    const variantInfoFilter = {
       categoryVariantInfoFilters: {},
       numericVariantInfoFilters: {},
     };
@@ -46,11 +47,11 @@ export class Query implements QueryInterface {
   }
 
   addCategoryFilter(key: string, value: string[]) {
-    (this.categoryFilters as { [key: string]: any })[key] = value;
+    (this.categoryFilters as Indexable)[key] = value;
   }
 
   addNumericFilter(key: string, min: string, max: string) {
-    (this.numericFilters as { [key: string]: any })[key] = {
+    (this.numericFilters as Indexable)[key] = {
       min: min.toString(),
       max: max.toString(),
     };