Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why move a surfel's center by 3 sigma? #44

Open
JzHuai0108 opened this issue Apr 8, 2023 · 1 comment
Open

Why move a surfel's center by 3 sigma? #44

JzHuai0108 opened this issue Apr 8, 2023 · 1 comment

Comments

@JzHuai0108
Copy link

Dear authors,

I appreciate your great work.

This question arises from the code line

center += 3 * sqrt(eva0) * direct;

To me, this line shifts the center along the minor axis by 3 sigma.
The following lines split the voxel into 8 cubes, and check their planarity based on the minimum eigenvalue.
All sounds reasonable except for the above line.
So why the shift?

@Zale-Liu
Copy link
Member

It is our new plane determination method which is not used in this project. More details can be found in "https://arxiv.org/abs/2305.00287".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants