Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue in fix T0 #38

Open
huanglilong opened this issue Jan 11, 2023 · 2 comments
Open

issue in fix T0 #38

huanglilong opened this issue Jan 11, 2023 · 2 comments

Comments

@huanglilong
Copy link

x_stats[j].p = x_stats[j].p - x_stats[j].R * x_stats[0].R.transpose() * x_stats[0].p;

@Zale-Liu actually, x_stats[0].p and x_stats[j].p in global frame, x_stats[j].R is from body frame to global frame
origin code:

x_stats[j].p =
    x_stats[j].p - x_stats[j].R * x_stats[0].R.transpose() * x_stats[0].p;
x_stats[j].R = x_stats[j].R * x_stats[0].R.transpose();

fixed code:

x_stats[j].p = x_stats[0].R.transpose() *(x_stats[j].p - x_stats[0].p);
x_stats[j].R = x_stats[0].R.transpose() * x_stats[j].R;
@huanglilong
Copy link
Author

thanks for great works! @Zale-Liu
initial pointcloud in global frame with noise poses:
image
optimized pointcloud in global frame with optimized poses:
image

@Zale-Liu
Copy link
Member

Yes, you are right. It is a bug I forget to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants