Add filter to override the RS_CSV_Helper class #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks meaningful. Did you tested on php5.3? |
|
@hissy we've not yet tested this on 5.3 but we will be in the next couple of weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the
RS_CSV_Helperclass to be customised with a newreally_simple_csv_helper_classfilter - the same way as thereally_simple_csv_importer_classfilter works.My reason for doing this is that I am importing taxonomy data rather than posts and the importer will report an 'invalid post type' error. I also want to trim white space from the column headings.