Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP-904: Allow autoMaxTokenAssociation to accept -1 & TokenReject #360

Merged
merged 10 commits into from
Jul 26, 2024
Merged

HIP-904: Allow autoMaxTokenAssociation to accept -1 & TokenReject #360

merged 10 commits into from
Jul 26, 2024

Conversation

RickyLB
Copy link
Contributor

@RickyLB RickyLB commented Jun 21, 2024 •
edited
Loading

Signed-off-by: Ricky Saechao ricky@launchbadge.com

Description:

This PR contains HIP-904 related features such as allowing unlimited max token associations to an account and token rejections.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

RickyLB added 3 commits June 21, 2024 11:30
@RickyLB
feat(hip-904): change maxAutomaticAssociation to Int32
62d5af9 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@RickyLB
chore: update protobufs
dd2f9d3 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@RickyLB
chore: update existing tests for maxAutomaticTokenAssociation
8435cf2 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@RickyLB RickyLB changed the title feat(hip-904): change maxAutomaticAssociation to Int32 HIP-904: Allow autoMaxTokenAssociation to accept -1 Jun 21, 2024
@RickyLB
feat(hip-904): add e2e test for AccountUpdate
56e7bce 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
RickyLB added 2 commits July 12, 2024 16:21
@RickyLB
chore: update protobufs
192b5f3 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@RickyLB
feat(hip-904): add token reject transaction
6663322 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@RickyLB RickyLB force-pushed the feat/hip-904 branch 2 times, most recently from 69e6886 to 333e79a Compare July 23, 2024 18:01
RickyLB added 2 commits July 23, 2024 11:18
@RickyLB
feat(hip-904): add token reject tests
15ec9ed 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@RickyLB
chore: update Status list
74cb607 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@RickyLB RickyLB changed the title HIP-904: Allow autoMaxTokenAssociation to accept -1 HIP-904: Allow autoMaxTokenAssociation to accept -1 & TokenReject Jul 23, 2024
@RickyLB RickyLB marked this pull request as ready for review July 23, 2024 18:28
@RickyLB RickyLB requested review from a team as code owners July 23, 2024 18:28
@RickyLB RickyLB requested a review from rwalworth July 23, 2024 18:28
RickyLB added 2 commits July 23, 2024 11:56
@RickyLB
fix: change auto token association in e2e test
0a21cec 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@RickyLB
fix: create fungible token for TokenReject e2e
8bff952 
Signed-off-by: Ricky Saechao <ricky@launchbadge.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@RickyLB RickyLB merged commit 6500d03 into hiero-ledger:main Jul 26, 2024
10 checks passed
@RickyLB RickyLB deleted the feat/hip-904 branch July 26, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheng-Long Sheng-Long Sheng-Long approved these changes

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth was automatically assigned from hashgraph/hedera-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RickyLB @Sheng-Long