Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 335 update ci workflows for best practices and standards #336

Merged

Conversation

rbarker-dev
Copy link
Member

Description:

Updated the workflows to meet. best-practices/standards

Related issue(s):

Fixes #335

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarker-dev rbarker-dev linked an issue Apr 16, 2024 that may be closed by this pull request
@rbarker-dev rbarker-dev self-assigned this Apr 16, 2024
@rbarker-dev rbarker-dev requested a review from nathanklick April 16, 2024 14:47
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarker-dev rbarker-dev requested a review from RickyLB April 22, 2024 20:09
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
both places. Looking into that more.

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarker-dev rbarker-dev requested a review from nathanklick May 7, 2024 17:40
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@RickyLB RickyLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RickyLB RickyLB merged commit 1355040 into main May 7, 2024
11 checks passed
@RickyLB RickyLB deleted the 335-update-ci-workflows-for-best-practices-and-standards branch May 7, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI workflows for best practices and standards
3 participants