fix(ecsda): return ecdsa signature with a normalized s value #2888
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leckey <ryan@calaxy.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
Some of the unit tests are failing, can you check why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ECDSA message signature generated by the JS SDK does not verify in the Rust SDK.
When exploring signing a message with
PrivateKeyin the JS SDK and verifying it with the Rust SDK, I noticed that the JS SDK does not return a normalizedsvalue in the ECDSA signature.This is not a breaking change as the underlying
ellipticlibrary validates both normalized and non-normalized signatures but other SDKs only validate normalized signatures.It is documented here - https://github.com/indutny/elliptic/wiki - that we need to use
canonical: trueto be Crypto-compatible.