feat(TCK): Dockerized TCK server #2868
Conversation
…uisites for the tests to run, added README Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
force-pushed
the
feat/tck-server-dockerize
branch
from
1ca6696 to
7c4a897
Compare
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
force-pushed
the
feat/tck-server-dockerize
branch
from
f705bd2 to
e06954c
Compare
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
…tnet within Taskfile Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
tck/sdk_data.ts
Outdated
| this.client.setNetwork({ | ||
| "host.docker.internal:50211": new AccountId(3), | ||
| }); | ||
| } |
There was a problem hiding this comment.
Shouldn't this be set by the TCK? Isn't it the TCK's job to set the network setup with a setup JSON-RPC call?
There was a problem hiding this comment.
It has been configured on both the TCK server and client.
Today, we introduced a cross-platform enhancement in the Docker Compose file, utilizing the original network node container from the local node. Additionally, within the TCK client (TCK repository), we updated the JSON-RPC server URL to point to the newly created TCK server container.
Meanwhile, calls from the TCK client container (TCK repo) to the consensus and mirror nodes now directed to the containers (mirror-node-rest & network-node) created by starting the local node.
tck/README.md
Outdated
|
|
||
| # Start All TCK Tests with Docker 🐳 | ||
|
|
||
| This guide will help you set up and start the TCK server, local node and run all TKC tests using Docker. Follow these steps to ensure all dependencies are installed and the server runs smoothly. |
There was a problem hiding this comment.
| This guide will help you set up and start the TCK server, local node and run all TKC tests using Docker. Follow these steps to ensure all dependencies are installed and the server runs smoothly. | |
| This guide will help you set up and start the TCK server, local node and run all TCK tests using Docker. Follow these steps to ensure all dependencies are installed and the server runs smoothly. |
|
|
||
| ```bash | ||
| task start-all-tests | ||
| ``` |
There was a problem hiding this comment.
I'm a bit confused by these instructions, do these all need to be run every time? Or are there setups steps I can just run once and not have to worry about again if I'm doing repeated testing? I think it may be beneficial to add another header after Setup Instructions to help differentiate the steps that involve setting up and those that involve running the tests.
There was a problem hiding this comment.
I believe they are not necessary since they simply explain what the Taskfile commands do, which is already documented within the Taskfile itself. Therefore, I have updated the README accordingly.
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
…dditional step in the Taskfile for dowloading the client image Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
…iero-sdk-js into feat/tck-server-dockerize Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Description:
This PR adds a
Dockerfilefor building a TCK server image and aTaskfileto allow all TCK test components to be started at onceRelated issue(s):
#2867
Checklist