test: add topic info tests #2756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
0xivanov
reviewed
Jan 9, 2025
| ); | ||
| }); | ||
|
|
||
| it("should decode/encode correctly", function () { |
There was a problem hiding this comment.
doesn't this test that is calling from/to bytes call from/to protobuf? - meaning this test is covering what the rest of the tests are covering?
There was a problem hiding this comment.
Not sure if the coverage is gonna say that all the lines are covered this way. It's going to take additional time, I am not sure if it's worth the effort to test this considering the slow CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds TopicInfo unit tests
Related issue(s): #1219
Checklist