Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta release v2.41.0-beta.1 #2105

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

Beta release v2.41.0-beta.1

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb01e23) 76.24% compared to head (c8d5fd9) 84.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2105      +/-   ##
===========================================
+ Coverage    76.24%   84.23%   +7.98%     
===========================================
  Files          305      305              
  Lines        76104    76104              
===========================================
+ Hits         58027    64105    +6078     
+ Misses       18077    11999    -6078     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@agadzhalov agadzhalov self-requested a review January 31, 2024 10:50
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/integration/AccountBalanceIntegrationTest.js Outdated Show resolved Hide resolved
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

66.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@svetoslav-nikol0v svetoslav-nikol0v merged commit ce12538 into develop Feb 1, 2024
13 of 14 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the release/v2.41.0-beta.1 branch February 1, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants