Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DUPLICATE_TRANSACTION error for Queries #2190

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Jan 23, 2025

Description:

This PR changes:

  1. Makes running integration tests in parallel, with workers equal to the machine cores.
  2. Removes the Thread.sleep during ContractFunctionParametersIntegrationTest, which causes the consensus node to return BUSY
  3. When the SDK gets status BUSY from the network, we generate new payment transaction ID, this prevents having duplicate transactions.
  4. Introduces re-submission for a given transaction, when THROTTLED_AT_CONSENSUS occures.

Related issue(s):

Fixes #

Notes for reviewer:

  1. Before this change, the integration tests took 11-13 min, now they take under 5.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Jan 23, 2025
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@@ -4,6 +4,7 @@
import com.google.common.base.MoreObjects;
import java.time.Duration;
import java.util.Collections;
import java.util.List;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the changes here are spotlessApply

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant