Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for deleted accounts in the isValidAlias function call #18002

Open
15 tasks
lukelee-sl opened this issue Feb 21, 2025 · 0 comments
Open
15 tasks

Add check for deleted accounts in the isValidAlias function call #18002

lukelee-sl opened this issue Feb 21, 2025 · 0 comments
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.

Comments

@lukelee-sl
Copy link
Contributor

Background

The isValidAccount function does not check for deleted accounts.

Acceptance Criteria

Add the check for deleted accounts during function processing.
Add tests to ensure that deleted accounts return false.

Dependencies

No response

Definition of Ready (DoR) Checklist

  • Clear acceptance criteria
  • Clear and detailed description
  • Dependencies identified
  • Links to documentation
  • Should be completable in 2-3 Days
  • Initial draft of Low-level design document
  • At least high level test plan
  • Groomed/Estimated

Definition of Done (DoD) Checklist

  • Acceptance Criteria complete
  • No Codacy issues greater than minor (in new code)
  • JavaDocs updated/created
  • Code commented
  • Unit tests created/updated
  • 80% test code coverage (in new code)
  • Happy Path and major negative cases in HAPI tests as applicable
@lukelee-sl lukelee-sl added Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. Bug An error that causes the feature to behave differently than what was expected based on design. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.
Projects
None yet
Development

No branches or pull requests

1 participant