Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectively cherry pick EnhancedKeyLoader changes from the 0.59 release to the 0.58 release #17951

Open
nathanklick opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Milestone

Comments

@nathanklick
Copy link
Contributor

Description

In the release/0.58 branch, the EnhancedKeyLoader still uses the AddressBookUtils.isLocal() method for identifying which private keys should be present. The release/0.59 branch uses the -local cli switch and/or the nodesToRun environment variable to determine which private keys must be present on disk.

The above logic in release/0.59 needs to be cherry picked back to the release/0.58 branch. This is required to support multi-cluster deployments with overlapping internal IP ranges.

@nathanklick nathanklick added Bug An error that causes the feature to behave differently than what was expected based on design. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Feb 19, 2025
@nathanklick nathanklick added this to the v0.58 milestone Feb 19, 2025
@nathanklick nathanklick self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. P0 An issue impacting production environments or impacting multiple releases or multiple individuals.
Projects
None yet
Development

No branches or pull requests

1 participant