Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: loading abstract to the dataframe #5

Merged
merged 9 commits into from
Jul 19, 2024
Merged

feat: loading abstract to the dataframe #5

merged 9 commits into from
Jul 19, 2024

Conversation

wenhwang97
Copy link
Collaborator

  • Add scripts for loading abstract to the dataframe in frp-cli
  • Create notebook file for exploring abstract's contribution to the matching

@wenhwang97 wenhwang97 requested a review from cbolles July 17, 2024 18:34
cbolles
cbolles requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@cbolles cbolles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, just some minor suggestions

packages/frp/frp/scholarly.py Show resolved Hide resolved
packages/frp/frp/scholarly.py Show resolved Hide resolved
@wenhwang97 wenhwang97 requested a review from cbolles July 18, 2024 13:10
cbolles
cbolles approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@cbolles cbolles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@wenhwang97 wenhwang97 merged commit b5b203a into main Jul 19, 2024
3 checks passed
@wenhwang97 wenhwang97 deleted the abstract branch July 19, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbolles cbolles cbolles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenhwang97 @cbolles