HBX-2614 - Check isNullable() in BasicPOJOClass::isRequiredInConstruc…

…tor. Restores previous Minimal Constructors behavior lost when isNullable() check removed from core org.hibernate.mapping.Property.isOptional().
hibernate · Oct 17, 2023 · c42c9a9 · c42c9a9
1 parent 5b63c2f
commit c42c9a9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/java/org/hibernate/tool/hbm2x/pojo/BasicPOJOClass.java b/src/java/org/hibernate/tool/hbm2x/pojo/BasicPOJOClass.java
@@ -825,7 +825,9 @@ protected boolean isRequiredInConstructor(Property field) {
 			return false;
 		}
 		if(field.getValue()!=null) {			
-			if (!field.isOptional() && (field.getValueGenerationStrategy() == null || field.getValueGenerationStrategy().getGenerationTiming().equals(GenerationTiming.NEVER))) {				
+			if (!(field.isOptional() || field.getValue().isNullable()) && 
+					(field.getValueGenerationStrategy() == null || 
+					 field.getValueGenerationStrategy().getGenerationTiming().equals(GenerationTiming.NEVER))) {				
 				return true;
 			} else if (field.getValue() instanceof Component) {
 				Component c = (Component) field.getValue();