HHH-18724 Take constraint composition type into account when determining nullable state of a Column #9092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wytzevanderploeg
force-pushed
the
HHH-18724
branch
from
3c842b1
to
bafc6a8
Compare
gavinking
requested changes
Oct 15, 2024
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
wytzevanderploeg
force-pushed
the
HHH-18724
branch
from
bafc6a8
to
48369e2
Compare
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
wytzevanderploeg
force-pushed
the
HHH-18724
branch
2 times, most recently
from
4cbef2e
to
0e343dc
Compare
gavinking
reviewed
Oct 15, 2024
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Oct 15, 2024
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
wytzevanderploeg
force-pushed
the
HHH-18724
branch
from
0e343dc
to
8e99cf1
Compare
|
Found an edge case that needs fixing, will mark as draft for now. |
…ing nullable state of a Column
wytzevanderploeg
force-pushed
the
HHH-18724
branch
from
8e99cf1
to
d18bef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-18724