HHH-17246 - Guard against Sybase being configured for truncating trailing zeros #9079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Fixed
Show fixed
Hide fixed
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Fixed
Show fixed
Hide fixed
|
@jrenaat It should be possible to detect that Sybase is configured like this, right? Just like we detect certain things about how MySQL or Oracle is configured, when we instantiate their dialects. I think we should start logging warnings for such "bad" config, i.e. this thing, and also non-ANSI nulls. |
beikov
requested changes
Oct 11, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UUIDasVarBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Outdated
Show resolved
Hide resolved
I tried to find out how to do this, but failed miserably ... |
jrenaat
force-pushed
the
HHH-17246_SybaseUUID
branch
from
eef475e
to
549af2f
Compare
beikov
reviewed
Oct 11, 2024
hibernate-core/src/test/java/org/hibernate/orm/test/id/uuid/SybaseASEUUIDTest.java
Show resolved
Hide resolved
jrenaat
force-pushed
the
HHH-17246_SybaseUUID
branch
from
549af2f
to
5fc034b
Compare
beikov
reviewed
Oct 15, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/UuidAsBinaryJdbcType.java
Outdated
Show resolved
Hide resolved
beikov
reviewed
Oct 15, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/UUIDJavaType.java
Outdated
Show resolved
Hide resolved
jrenaat
force-pushed
the
HHH-17246_SybaseUUID
branch
from
5fc034b
to
ba8451e
Compare
| @@ -41,7 +41,7 @@ | |||
| return ToStringTransformer.INSTANCE.transform( value ); | |||
| } | |||
|
|
|||
| public UUID fromString(CharSequence string) { | |||
| public UUID fromString(CharSequence string) { | |||
Check notice
Code scanning / CodeQL
Missing Override annotation
…ling zeros Signed-off-by: Jan Schatteman <jschatte@redhat.com>
jrenaat
force-pushed
the
HHH-17246_SybaseUUID
branch
from
ba8451e
to
684bb87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-17246