-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jocooks.com scraper #1134
add jocooks.com scraper #1134
Conversation
This generally looks good to me, thank you @Mooree003! Out of interest: for the |
Co-authored-by: James Addison <55152140+jayaddison@users.noreply.github.com>
The only reason was in another scraper i created this method seemed to not work as intended so I reused my previous method however the |
This reverts commit eda632b.
Thanks @Mooree003! From some testing here: the And a question / optional feature request: it looks like the recipe webpage includes nutritional info in the |
Interesting I thought I removed these 😂. I'll add the nutritional info and remove the functions |
👍 all looks good to me... ...but I'm going to add one more suggestion, because even though |
No worries! Added now |
changes addressed |
@Mooree003 , looks great thanks! merging now |
This is a PR for recipe-scrapers to include recipes from jocooks. There was full schema support except for ingredient groups which had to be configured manually.
Resolves #1129