Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 site additions #1133

Merged
merged 9 commits into from
May 11, 2024
Merged

5 site additions #1133

merged 9 commits into from
May 11, 2024

Conversation

jknndy
Copy link
Collaborator

@jknndy jknndy commented May 9, 2024

  • allthehealthythings.com
  • dinneratthezoo.com
  • evolvingtable.com
  • kristineskitchenblog.com
  • onesweetappetite.com

@jknndy jknndy marked this pull request as ready for review May 9, 2024 00:17
@jayaddison
Copy link
Collaborator

These look good to me - I'm going to take a second look in a few hours to re-confirm.

Out of interest, was it easier/more-difficult/no-different to develop these scrapers without all of the self.schema.* calls in place for each field?

@jayaddison
Copy link
Collaborator

It's nitpicky, but I'd suggest that we move the ratings-count corrections into a separate pull request; that should help make the intention of both pull requests clearer (and matches the pull request title here to the changeset).

@jknndy
Copy link
Collaborator Author

jknndy commented May 11, 2024

It's nitpicky, but I'd suggest that we move the ratings-count corrections into a separate pull request; that should help make the intention of both pull requests clearer (and matches the pull request title here to the changeset).

reverted, i'll open in a new pr with those changes

@jknndy jknndy merged commit 371a49e into hhursev:main May 11, 2024
19 checks passed
@jknndy jknndy deleted the library-additions branch October 17, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants